Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vuex ui-store instead of global events from event-bus in UI interactions #44

Closed
filrak opened this issue Oct 6, 2017 · 3 comments
Closed

Use vuex ui-store instead of global events from event-bus in UI interactions #44

filrak opened this issue Oct 6, 2017 · 3 comments
Assignees
@mercs600
Labels
good first issue Tasks that requires just basic understanding of Vue Storefront

Comments

@filrak
Copy link
Collaborator

filrak commented Oct 6, 2017

Now we have 3 events for toggling overlay, microcart and sidebar. It would be much better if we move all ui-related common events to one store. There is ui-store.js atm providing overlay, microcart and sidebar interactions but it's not used.

Definition of done: sidebar, overlay and microcart ui interactions are fired from ui-store.js not from global event bus
@filrak filrak added good first issue Tasks that requires just basic understanding of Vue Storefront enhancement labels Oct 6, 2017
@mercs600
Copy link
Collaborator

@patrykpiston are you working on it ? I could refactore evens to ui-store

@mercs600 mercs600 self-assigned this Oct 18, 2017
@sudo-at-night
Copy link
Contributor

sudo-at-night commented Oct 18, 2017 via email •
edited

mercs600 added a commit to mercs600/vue-storefront that referenced this issue Oct 18, 2017
@mercs600
[vuestorefront#44] Use vuex ui-store instead of global events from ev…
138696d 
…ent-bus in UI interactionse
@mercs600 mercs600 mentioned this issue Oct 20, 2017
Closed
mercs600 added a commit to mercs600/vue-storefront that referenced this issue Oct 20, 2017
@mercs600
[vuestorefront#44] Remove interactions between components in core ui-…
397435a 
…store
mercs600 added a commit to mercs600/vue-storefront that referenced this issue Oct 21, 2017
@mercs600
[vuestorefront#44] Remove interactions between components in core ui-…
38361e6 
…store
mercs600 added a commit to mercs600/vue-storefront that referenced this issue Oct 21, 2017
@mercs600
[vuestorefront#44] Use vuex ui-store instead of global events from ev…
2d701b3 
…ent-bus in UI interactionse
mercs600 added a commit to mercs600/vue-storefront that referenced this issue Oct 21, 2017
@mercs600
[vuestorefront#44] Prototype of vuex store extending
815478b
mercs600 added a commit to mercs600/vue-storefront that referenced this issue Oct 21, 2017
@mercs600
[vuestorefront#44] Fix no-scroll state
514d45e
mercs600 added a commit to mercs600/vue-storefront that referenced this issue Oct 21, 2017
@mercs600
[vuestorefront#44] Fix minicart counter
9122357
mercs600 added a commit to mercs600/vue-storefront that referenced this issue Oct 22, 2017
@mercs600
[vuestorefront#44] Remove unused ui-store file
161458c
filrak added a commit that referenced this issue Oct 22, 2017
@filrak
Merge pull request #144 from mercs600/feature/44
ec5625c 
[#44] Remove unused ui-store file
@mercs600
Copy link
Collaborator

I think we can close it.

@johnwalz97 johnwalz97 mentioned this issue Feb 2, 2024
Open
sethidden pushed a commit that referenced this issue Apr 5, 2024
@Olbix @WojtekTheWebDev
Alokai refactor (#44)
0934374 
* rebranding

* rebranding

* rebranding

* update readmes

---------

Co-authored-by: krystian wlodarski <kwlodarski@vuestorefront.io>
Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com>
sethidden pushed a commit that referenced this issue Apr 5, 2024
@Olbix @WojtekTheWebDev @sethidden
Alokai refactor (#44)
12be191 
* rebranding

* rebranding

* rebranding

* update readmes

---------

Co-authored-by: krystian wlodarski <kwlodarski@vuestorefront.io>
Co-authored-by: Wojciech Sikora <35867383+WojtekTheWebDev@users.noreply.github.com>
@johnwalz97 johnwalz97 mentioned this issue Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mercs600 mercs600

Labels
good first issue Tasks that requires just basic understanding of Vue Storefront
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mercs600 @filrak @sudo-at-night