Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ID to Loggers in core factories #5351

Closed
1 of 3 tasks
Fifciu opened this issue Dec 23, 2020 · 0 comments
Closed
1 of 3 tasks

Add ID to Loggers in core factories #5351

Fifciu opened this issue Dec 23, 2020 · 0 comments
Assignees
@lukaszjedrasik
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront Next Issues/bugs for Vue Storefront Next
Projects
Next Core 1.0

Comments

@Fifciu
Copy link
Collaborator

Fifciu commented Dec 23, 2020 •
edited by sync-by-unito bot

What is the motivation for adding / enhancing this feature?

Here: https://github.com/vuestorefront/vue-storefront/pull/5346/files#diff-e26f6b347d1f8f8bcb8bfd301d9e170be8bd189c89c4084b391e628001f69495R26

I added id to the Logger message from compostables that have it. We need to add it to the other Logger calls inside core factories.

What are the acceptance criteria

  • Add ID to Logger calls inside core factories

Version of Vue Storefront

  • Vue Storefront
  • Vue Storefront Next
@Fifciu Fifciu added good first issue Tasks that requires just basic understanding of Vue Storefront feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can 1: Easy Next Issues/bugs for Vue Storefront Next labels Dec 23, 2020
@filrak filrak added this to Backlog in Next Core 1.0 via automation Dec 23, 2020
@lukaszjedrasik lukaszjedrasik mentioned this issue Jan 7, 2021
Merged
6 tasks
@filrak filrak closed this as completed Jan 12, 2021
Next Core 1.0 automation moved this from Backlog to Done Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukaszjedrasik lukaszjedrasik

Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront Next Issues/bugs for Vue Storefront Next
Projects
No open projects
Next Core 1.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@filrak @Fifciu @lukaszjedrasik