Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next: Add id to loggers in core factories #5380

Merged
merged 4 commits into from
Jan 11, 2021

Conversation

lukaszjedrasik
Copy link
Contributor

@lukaszjedrasik lukaszjedrasik commented Jan 7, 2021

Related Issues

closes #5351

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE

  • Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@lukaszjedrasik lukaszjedrasik added the Next Issues/bugs for Vue Storefront Next label Jan 7, 2021
@coveralls
Copy link

coveralls commented Jan 7, 2021

Pull Request Test Coverage Report for Build 469118127

  • 5 of 5 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 95.553%

Totals Coverage Status
Change from base Build 469050512: 0.8%
Covered Lines: 704
Relevant Lines: 730

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 469118127

  • 0 of 5 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 95.504%

Totals Coverage Status
Change from base Build 469050512: 0.7%
Covered Lines: 333
Relevant Lines: 341

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 7, 2021

Pull Request Test Coverage Report for Build 469150913

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.793%

Totals Coverage Status
Change from base Build 469050512: 0.0%
Covered Lines: 1437
Relevant Lines: 1496

💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2021

💙 vsf-next-demo successfully deployed at https://e32c7261306e5193937eb42fff6e9408e00fd965.vsf-next-demo.preview.storefrontcloud.io

@filrak filrak merged commit 65f354d into next Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants