Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty payload inside clearCurrentUser action #5565

Closed
1 of 2 tasks
lukaszjedrasik opened this issue Feb 22, 2021 · 0 comments
Closed
1 of 2 tasks

Empty payload inside clearCurrentUser action #5565

lukaszjedrasik opened this issue Feb 22, 2021 · 0 comments
Assignees
Labels
bug Bug reports VSF1 Issues in regards to VSF1
Milestone

Comments

@lukaszjedrasik
Copy link
Contributor

Current behavior

As you can see here https://github.com/vuestorefront/vue-storefront/blob/master/core/modules/user/store/actions.ts#L218 payload is the empty string ('').

Now look at this line https://github.com/vuestorefront/vue-storefront/blob/master/core/modules/user/store/mutations.ts#L8. It works only because

'someString'.newToken === undefined

Expected behavior

Pass payload with correct value eg.

commit(types.USER_TOKEN_CHANGED, { newToken: null })

Version of Vue Storefront

  • Vue Storefront
  • Vue Storefront Next
@lukaszjedrasik lukaszjedrasik added bug Bug reports VSF1 Issues in regards to VSF1 labels Feb 22, 2021
@Fifciu Fifciu added this to the 1.12.3 milestone Jun 22, 2021
Fifciu added a commit that referenced this issue Jun 24, 2021
…CurrentUser

fix: #5565/empty payload clear current user
@Fifciu Fifciu closed this as completed Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports VSF1 Issues in regards to VSF1
Projects
None yet
Development

No branches or pull requests

2 participants