Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Product Child SKU is not updated on Config Change with urlDispatcher enables #5981

Closed
4 of 7 tasks
domideimel opened this issue Jun 10, 2021 · 0 comments
Closed
4 of 7 tasks
Assignees
Labels
bug Bug reports VSF1 Issues in regards to VSF1

Comments

@domideimel
Copy link
Contributor

Current behavior

When you change a configuration of a configurable product and have seo.urlDispatcher enabled, the param of the url is not updated. This causes a miscalculation of a discount calculation and prices not updating correctly.

The url behavior can be reproduced by simply changing the color or size of the product in the demo instance: https://demo.vuestorefront.io/tristan-endurance-tank.html?childSku=MT02-XS-Red

Expected behavior

To update the url properly with the correct child sku

Steps to reproduce the issue

Simply change the color of the color or size of the product: https://demo.vuestorefront.io/tristan-endurance-tank.html?childSku=MT02-XS-Red

Version of Vue Storefront

  • Vue Storefront
  • Vue Storefront Next

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer. (doesn't apply to Next)

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Chrome 92
  • OS: MacOS 11.4
  • Node: v12.17.0
  • Code Version: 1.12.3

Additional information

@domideimel domideimel added the bug Bug reports label Jun 10, 2021
@lukaszjedrasik lukaszjedrasik added the VSF1 Issues in regards to VSF1 label Jun 10, 2021
Fifciu added a commit that referenced this issue Jun 21, 2021
…ange-filter

fix: update url with properly child sku
@Fifciu Fifciu closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports VSF1 Issues in regards to VSF1
Projects
None yet
Development

No branches or pull requests

3 participants