Feature - async/await support #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Niiiiice! Do you have before/after bundle sizes with this polyfills? |
|
@filrak Sure, i've done bundle analyzer. It's adding ~20kB for now, but first - it's only temporary workaround till we get full babel7; second - we need to work on vendor itself because it's huge anyway; and third - i think it's totally worth it for code readability like up above.
|
|
Perfect :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description and why it's useful
I've added babel-polyfill to our build process, mostly to support async/await.
After full integration with babel7 this won't be necessary but we can write a readable async code right away! :)
Screenshots of visual changes before/after (if there are any)
I'll show Home.vue asyncData, because it's not so clear in diff mode
so before:
aaand after:
