Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/2120-picture-switching-when-entering-product #2123

Merged
merged 1 commit into from
Jan 3, 2019
Merged

bugfix/2120-picture-switching-when-entering-product #2123

merged 1 commit into from
Jan 3, 2019

Conversation

vue-kacper
Copy link
Contributor

Related issues

#2120

Short description and why it's useful

Optimized picture switching when entering product page

@vue-kacper vue-kacper requested a review from pkarw January 1, 2019 21:39
@pkarw pkarw merged commit 6f187a6 into vuestorefront:develop Jan 3, 2019
@pkarw
Copy link
Collaborator

pkarw commented Jan 3, 2019

Thanks! I have merged this in however in #2120 I was thinking rather about kind of carousel lazyloding - I mean loading single static picture then loading the carousel itself -
Because this way it should positively affect the performance of first page load for the product

@vue-kacper
Copy link
Contributor Author

@pkarw sure :) since we are planing to change vue-carousel component in #2111 it would be better to implement lazy loading based on new carousel plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkarw pkarw pkarw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vue-kacper @pkarw