Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web share module + depreciations #2143

Merged
merged 16 commits into from
Jan 11, 2019
Merged

Conversation

filrak
Copy link
Collaborator

@filrak filrak commented Jan 8, 2019

Related issues

#2099

Short description and why it's useful

I added tiny module just to have sth new in this release. Also depreciated some parts of the app that were meant to be depreciated in 1.7 (unfortunately due to 2 weeks off I wouldnt be able to depreciate everything we planned to in favour of doing performance optimisation)

  • added Web Share API module
  • depreciated old way of extending VS stores (extendStore)
  • removed unused ValidationError class from Ajv
  • merged store helpers with core helpers and deleted duplicated ones (just libs and types left!)
  • cleanup of unused imports

Screenshots of visual changes before/after (if there are any)

image
image

(if you made any changes in the UI layer please provide before/after screenshots)

Screenshot of passed e2e tests (if you are using our standard setup as a backend)

(run yarn test:e2e and paste the results. If you are not using our standard backend setup or demo.vuestorefront.io you can ommit this step)

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@filrak filrak requested review from pkarw and patzick January 8, 2019 16:54
@filrak filrak changed the title Web share module + depreciations WIP: Web share module + depreciations Jan 8, 2019
@filrak filrak changed the title WIP: Web share module + depreciations Web share module + depreciations Jan 8, 2019
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature:)
Only i'd left old helpers with warning and instruction to assure smooth upgrade.

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the note from @patzick on extending the Upgrade notes

@pkarw
Copy link
Collaborator

pkarw commented Jan 9, 2019

@filrak Can we add to Recipes how to extend existing Vuex stores?

  • how to override the whole module
  • how to add action to an existing module
  • how to override action from an existing module

?

@filrak
Copy link
Collaborator Author

filrak commented Jan 9, 2019

@patzick good point,im writing upgrade notes from theme diff anyway but i added it to local notes just inc ase, thanks ;) @pkarw yes

@filrak filrak merged commit 2dc22c3 into vuestorefront:develop Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants