Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regional characters in urls #2243

Merged
merged 5 commits into from
Jan 20, 2019

Conversation

Aekal
Copy link
Collaborator

@Aekal Aekal commented Jan 18, 2019

Short description and why it's useful

Before that change urls for e.g. category were incorrect, książki word was converted to ksiki, now after removing special characters it'll be ksiazki.

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@patzick
Copy link
Collaborator

patzick commented Jan 18, 2019

@Aekal could you check added size of this library in bundle analyzer?

@Aekal
Copy link
Collaborator Author

Aekal commented Jan 18, 2019

@patzick
zrzut ekranu 2019-01-18 o 13 47 11

@pkarw pkarw requested a review from patzick January 18, 2019 18:33
@filrak
Copy link
Collaborator

filrak commented Jan 20, 2019

According to bundlephobia there are no better alternatives so i guess we can merge it in ;) https://bundlephobia.com/result?p=remove-accents@0.4.2

@filrak filrak merged commit 1ed5cb4 into vuestorefront:develop Jan 20, 2019
@Aekal Aekal deleted the feature/url-accents branch January 20, 2019 18:02
@pkarw pkarw added this to the 1.8 milestone Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants