Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductAttribute.ts - check if values are an array or not. #2379

Merged
merged 1 commit into from
Feb 6, 2019
Merged

ProductAttribute.ts - check if values are an array or not. #2379

merged 1 commit into from
Feb 6, 2019

Conversation

afirlejczyk
Copy link
Contributor

@afirlejczyk afirlejczyk commented Feb 6, 2019

Short description and why it's useful

Small fix for showing attribute values (customAttributes) on Product Page.
Check if parsedValues is already an array.

Before:
attribute-before

After:
attribute-after

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@pkarw pkarw changed the base branch from master to develop February 6, 2019 16:07
@pkarw pkarw merged commit b1d0421 into vuestorefront:develop Feb 6, 2019
@patzick patzick added this to the 1.8 milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants