Bugfix/2449 menu not working on static pages #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarw
requested changes
Feb 19, 2019
|
I like this solution. We’re aiming at lean/dummy components so adding data prefetch shouldn’t be a general rule of thumb but I believe that layout is good place |
pkarw
requested changes
Feb 19, 2019
patzick
approved these changes
Feb 20, 2019
pkarw
approved these changes
Feb 20, 2019
|
Done! Thanks @filrak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
closes #2449
closes #2441
Short description and why it's useful
We were fetching menu data only on Home so it wasn't working on any other page if accessed directly from the URL. I updated Vue to v2.6 and used native
serverPrefetchto fetch sidebar menu data into SSR context right in the root component.