Bugfix/too early breadcrumbs change #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarw
approved these changes
Feb 20, 2019
|
@filrak is it still WIP? |
filrak
changed the title
|
nope, just contains #2464 . that needs to be merged first. 2 first files are refering to this PR |
patzick
approved these changes
Feb 21, 2019
|
The issue hasn't been yet solved by this PR :( It still exists |
pkarw
added a commit
that referenced
this pull request
Mar 2, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
none
Short description and why it's useful
Currently when switching from category to Product page breadcrumbs are changing too early.
I fixed this problem by maiing use of internal breadcrumbs in Product page. there are still some side effects to clean (get rid of global breadcrumbs store) and Changelog to be finished.
also depreciation of
@vue-storefront/storeneeds to be merged