Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add items minicart count type #2483

Merged
merged 6 commits into from
Feb 22, 2019
Merged

Feature/add items minicart count type #2483

merged 6 commits into from
Feb 22, 2019

Conversation

PaulEmich
Copy link

@PaulEmich PaulEmich commented Feb 22, 2019

Short description and why it's useful

Some people prefer to show the total items in the cart, instead of the sum of the cart item quantities. This PR adds a config settings which makes you able to modify the cart count based on it's value.

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pkarw pkarw requested a review from patzick February 22, 2019 21:22
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't have issue for that let's add PR number to easily track changes:)
Just apply this suggestion to changelog and we'll merge.

Thanks for this feature!

CHANGELOG.md Outdated Show resolved Hide resolved
@patzick
Copy link
Collaborator

patzick commented Feb 22, 2019

I've added PR number resolving conflict. So it's all good now!

@pkarw pkarw merged commit 2626f9e into vuestorefront:develop Feb 22, 2019
@pkarw
Copy link
Collaborator

pkarw commented Feb 22, 2019

Thanks!

@PaulEmich PaulEmich deleted the feature/add-items-minicart-count-type branch February 25, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants