Bugfix/#2450 show prices after adding product to cart in offline mode #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filrak
requested changes
Feb 27, 2019
filrak
approved these changes
Feb 27, 2019
pkarw
approved these changes
Feb 27, 2019
patzick
deleted the
bugfix/#2450-show-prices-after-adding-product-to-cart-in-offline-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
closes #2450
Short description and why it's useful
Shows regular price when there is no totals from server.
I also discovered, that cart summary is in
cart.state.platformTotalSegmentswhich is updated after response from server, so after adding new product summary still was not updated. So i made a reactive online helper and used it in getter which returns cart summary.New Vue.observable is pretty cool! 💥 :)
Upgrade Notes and Changelog