Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix range queries to elasticsearch #2746

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Fix range queries to elasticsearch #2746

merged 3 commits into from
Apr 24, 2019

Conversation

oskar1233
Copy link
Contributor

Since now, range queries were activated only if filter.value contained ALL of rangeOperators. This logic is obviously wrong.

This PR inverses the logic - we check if every filter.value key is one of rangeOperators.

Fix range queries to elasticsearch
069c59c 
Since now, range queries were activated only if `filter.value` contained ALL of `rangeOperators`. This logic is obviously wrong.

This PR inverses the logic - we check if every `filter.value` key is one of `rangeOperators`.
@pkarw pkarw requested a review from patzick April 17, 2019 10:35
pkarw
pkarw approved these changes Apr 17, 2019
View reviewed changes
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok for me

@pkarw
Copy link
Collaborator

pkarw commented Apr 17, 2019

Please just update the Changelog, ok?

@patzick patzick changed the base branch from master to hotfix/v1.8.5 April 17, 2019 11:08
@patzick patzick added this to the 1.8.5 milestone Apr 17, 2019
@patzick patzick changed the base branch from hotfix/v1.8.5 to release/1.9 April 17, 2019 11:36
@pkarw pkarw modified the milestones: 1.8.5, 1.9.0 Apr 17, 2019
patzick
patzick requested changes Apr 17, 2019
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please just update changelog.md

patzick
patzick approved these changes Apr 24, 2019
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog updated.

@patzick patzick merged commit 24da3a3 into vuestorefront:release/1.9 Apr 24, 2019
@oskar1233
Copy link
Contributor Author

@patzick Thanks for doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkarw pkarw pkarw approved these changes

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oskar1233 @pkarw @patzick