Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Move 'Clear cart' button to the upper part of the window #2765

Merged
merged 7 commits into from
Apr 24, 2019

Conversation

rafalpyska
Copy link
Contributor

@rafalpyska rafalpyska commented Apr 22, 2019

Related issues

#2697

Short description and why it's useful

Move "clear cart" button to the top of the cart. Additionaly, I've added conditional to clear cart button because it was displaying when there was no products in the cart.

Screenshots of visual changes before/after (if there are any)

before

after

Which environment this relates to

Test version (bugfix to new feature).

@pkarw
Copy link
Collaborator

pkarw commented Apr 23, 2019

Thanks! I belive we should consult it with the UX designer as this button shouldn’t look like the main CTA which is Go To Cart in here

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a UX review @StasiekDivante

@StasiekDivante
Copy link
Collaborator

A "clear cart" button can have the same style as "return to shipping" one + additional remove icon. We use this style for button through the demo as a secondary button.

To create visual clarity small 1px divider can be added beneath "shopping cart" header

Group

@pkarw
Copy link
Collaborator

pkarw commented Apr 23, 2019

Thanks, @StasiekDivante; @rafalpyska can You please adjust the styles?

@rafalpyska
Copy link
Contributor Author

rafalpyska commented Apr 23, 2019

@pkarw I've created new ClearCartButton component with appropriate styles and provided en-US translation. However, icon doesn't look the same as in the image above, despite the fact that I used appropriate material.io class. What about mobile view?

@pkarw
Copy link
Collaborator

pkarw commented Apr 24, 2019

@rafalpyska could You please provide us with the screenshots after changes?

@rafalpyska
Copy link
Contributor Author

rafalpyska commented Apr 24, 2019

@pkarw
Zrzut ekranu 2019-04-24 o 13 35 50

Mobile
Zrzut ekranu 2019-04-24 o 13 36 37

@pkarw pkarw merged commit 259d527 into vuestorefront:develop Apr 24, 2019
@rafalpyska
Copy link
Contributor Author

rafalpyska commented Apr 24, 2019

@pkarw I have added horizontal divider and decreased font size a little bit. But I see it's too late.

Zrzut ekranu 2019-04-24 o 14 49 02

@ArturDivante ArturDivante mentioned this pull request Apr 26, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants