-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Move 'Clear cart' button to the upper part of the window #2765
[BUGFIX] Move 'Clear cart' button to the upper part of the window #2765
Conversation
Thanks! I belive we should consult it with the UX designer as this button shouldn’t look like the main CTA which is Go To Cart in here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a UX review @StasiekDivante
Thanks, @StasiekDivante; @rafalpyska can You please adjust the styles? |
@pkarw I've created new ClearCartButton component with appropriate styles and provided en-US translation. However, icon doesn't look the same as in the image above, despite the fact that I used appropriate material.io class. What about mobile view? |
@rafalpyska could You please provide us with the screenshots after changes? |
@pkarw I have added horizontal divider and decreased font size a little bit. But I see it's too late. |
Related issues
#2697
Short description and why it's useful
Move "clear cart" button to the top of the cart. Additionaly, I've added conditional to clear cart button because it was displaying when there was no products in the cart.
Screenshots of visual changes before/after (if there are any)
Which environment this relates to
Test version (bugfix to new feature).