Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2806 add clear wishlist button #2923

Merged
merged 12 commits into from
May 21, 2019
Merged

Feature/2806 add clear wishlist button #2923

merged 12 commits into from
May 21, 2019

Conversation

aniamusial
Copy link
Contributor

@aniamusial aniamusial commented May 20, 2019

Related issues

closes #2806

Short description and why it's useful

It adds the "Clear wishlist" button and it gets the job done in one click, instead of many :)

Screenshots of visual changes before/after (if there are any)

Screenshot from 2019-05-20 11-08-33
Screenshot from 2019-05-20 11-08-20

Which environment this relates to

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@aniamusial aniamusial changed the base branch from master to develop May 20, 2019 09:20
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @aniamusial, just small changes from my side. Most important about click event and not using click.native

aniamusial and others added 6 commits May 20, 2019 17:10
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
@pkarw pkarw requested a review from patzick May 20, 2019 17:57
@patzick patzick merged commit 57e16f9 into vuestorefront:develop May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants