-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2806 add clear wishlist button #2923
Merged
patzick
merged 12 commits into
vuestorefront:develop
from
aniamusial:feature/2806-add-clear-wishlist-button
May 21, 2019
Merged
Feature/2806 add clear wishlist button #2923
patzick
merged 12 commits into
vuestorefront:develop
from
aniamusial:feature/2806-add-clear-wishlist-button
May 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarw
approved these changes
May 20, 2019
patzick
requested changes
May 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @aniamusial, just small changes from my side. Most important about click event and not using click.native
src/themes/default/components/core/blocks/Wishlist/ClearWishlistButton.vue
Outdated
Show resolved
Hide resolved
src/themes/default/components/core/blocks/Wishlist/Wishlist.vue
Outdated
Show resolved
Hide resolved
src/themes/default/components/core/blocks/Wishlist/Wishlist.vue
Outdated
Show resolved
Hide resolved
src/themes/default/components/core/blocks/Wishlist/Wishlist.vue
Outdated
Show resolved
Hide resolved
src/themes/default/components/core/blocks/Wishlist/Wishlist.vue
Outdated
Show resolved
Hide resolved
src/themes/default/components/core/blocks/Wishlist/Wishlist.vue
Outdated
Show resolved
Hide resolved
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
patzick
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
closes #2806
Short description and why it's useful
It adds the "Clear wishlist" button and it gets the job done in one click, instead of many :)
Screenshots of visual changes before/after (if there are any)
Which environment this relates to
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
Contribution and currently important rules acceptance