Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/#3056 remove back icon on product page #3069

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Bugfix/#3056 remove back icon on product page #3069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82f3113
show only menu icon in product page
patzick Jun 18, 2019
9fdb262
update changelog
patzick Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improve performace with preventing render 404 page on the server side if some of static content is missed, simple 404 response uses instead - [PHOENIX MEDIA](https://www.phoenix-media.eu/) - Yuri Boyko @yuriboyko, Anton Lobodenko @sniffy1988 (#3002)
- Added Products column change functionality - @vishal-7037 (#3017)
- Add support for api.url in the Task module - @basvanpoppel (#3011)
- Back icon on product page causing inconsistent behavior - @patzick (#3056)

### Fixed
- Special price got zeroed - @pkarw (#2940)
Expand Down
9 changes: 1 addition & 8 deletions src/themes/default/components/core/blocks/Header/Header.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,7 @@
<div class="row between-xs middle-xs" v-if="!isCheckoutPage || isThankYouPage">
<div class="col-md-4 col-xs-2 middle-xs">
<div>
<template v-if="!canGoBack">
<hamburger-icon class="p15 icon bg-cl-secondary pointer" v-if="!canGoBack" />
</template>
<template v-else>
<return-icon class="p15 icon bg-cl-secondary pointer" v-if="canGoBack" />
</template>
<hamburger-icon class="p15 icon bg-cl-secondary pointer" />
</div>
</div>
<div class="col-xs-2 visible-xs">
Expand Down Expand Up @@ -73,7 +68,6 @@ import CompareIcon from 'theme/components/core/blocks/Header/CompareIcon'
import HamburgerIcon from 'theme/components/core/blocks/Header/HamburgerIcon'
import Logo from 'theme/components/core/Logo'
import MicrocartIcon from 'theme/components/core/blocks/Header/MicrocartIcon'
import ReturnIcon from 'theme/components/core/blocks/Header/ReturnIcon'
import SearchIcon from 'theme/components/core/blocks/Header/SearchIcon'
import WishlistIcon from 'theme/components/core/blocks/Header/WishlistIcon'

Expand All @@ -85,7 +79,6 @@ export default {
HamburgerIcon,
Logo,
MicrocartIcon,
ReturnIcon,
SearchIcon,
WishlistIcon
},
Expand Down