Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3053] Fixed memory leak with enabled dynamicConfigReload. #3075

Merged
merged 5 commits into from
Jul 3, 2019
Merged

[3053] Fixed memory leak with enabled dynamicConfigReload. #3075

merged 5 commits into from
Jul 3, 2019

Conversation

dimasch
Copy link
Collaborator

@dimasch dimasch commented Jun 18, 2019

Related issues

closes #3053

Screenshots of visual changes before/after (if there are any)

2019-06-18_22-26-16
After stress test GC corrected flush memory usage:
2019-06-18_22-26-45

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@pkarw pkarw changed the base branch from develop to release/v1.10 June 19, 2019 06:15
@pkarw pkarw changed the base branch from release/v1.10 to develop June 19, 2019 06:16
@pkarw
Copy link
Collaborator

pkarw commented Jun 19, 2019

Thanks @dimasch however there is a problem with eslint causing CI to fail:

/home/travis/build/DivanteLtd/vue-storefront/core/scripts/server.js
  252:7  error  Variables should not be deleted  no-delete-var

Please fix it - even by adding the ignore

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do fix the CI bugs + add a changelog

@pkarw pkarw added this to the 1.11.0-rc.1 milestone Jun 19, 2019
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, but variables should not be deleted - http://linterrors.com/js/only-properties-should-be-deleted

Please also update changelog :)

core/scripts/server.js Outdated Show resolved Hide resolved
@patzick patzick added the not ready for merge PR is holded. Needs some clarifications or things that need to be finished. label Jun 28, 2019
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
@pkarw pkarw requested a review from patzick July 1, 2019 18:38
@pkarw
Copy link
Collaborator

pkarw commented Jul 1, 2019

@dimasch you missed the changelog update - please add a line on this fix there and we're merging this in :)

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patzick patzick removed the not ready for merge PR is holded. Needs some clarifications or things that need to be finished. label Jul 3, 2019
@patzick patzick merged commit 5c1943f into vuestorefront:develop Jul 3, 2019
@pkarw pkarw mentioned this pull request Nov 5, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants