-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3053] Fixed memory leak with enabled dynamicConfigReload. #3075
[3053] Fixed memory leak with enabled dynamicConfigReload. #3075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do fix the CI bugs + add a changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, but variables should not be deleted - http://linterrors.com/js/only-properties-should-be-deleted
Please also update changelog :)
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
@dimasch you missed the changelog update - please add a line on this fix there and we're merging this in :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Related issues
closes #3053
Screenshots of visual changes before/after (if there are any)
After stress test GC corrected flush memory usage:
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance