Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration for the max attempt request #3193

Merged
merged 8 commits into from
Jul 10, 2019

Conversation

cnviradiya
Copy link
Contributor

Related issues

closes #

Short description and why it's useful

  • Added configuration for the max attempt request in default.json to prevent many times attempt
  1. Max Network Task Attempts
  2. Max Cart Bypass Attempts

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

"queues": {
"maxNetworkTaskAttempts": 1,
"maxCartBypassAttempts": 1
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patzick
Copy link
Collaborator

patzick commented Jul 9, 2019

@cnviradiya could you also add info do docs, to describe what this config setting is doing?
This would really help devs to know what is it for and what to do with it :) for us it is clear now, but we should have in mind new developers.

cc @kkdg

@cnviradiya
Copy link
Contributor Author

@cnviradiya could you also add info do docs, to describe what this config setting is doing?
This would really help devs to know what is it for and what to do with it :) for us it is clear now, but we should have in mind new developers.

cc @kkdg

Yes, sure
I'll add info in docs.

@cnviradiya
Copy link
Contributor Author

@cnviradiya could you also add info do docs, to describe what this config setting is doing?
This would really help devs to know what is it for and what to do with it :) for us it is clear now, but we should have in mind new developers.

cc @kkdg

@patzick I've updated docs, please review it and share your feedback.
Thanks

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you! :)

@patzick patzick added this to the 1.11.0-rc.1 milestone Jul 10, 2019
@patzick patzick merged commit 771507c into vuestorefront:develop Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants