Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed swatches not rendering properly at product detail page #3206

Conversation

vishal-7037
Copy link
Contributor

Short description and why it's useful

  • Fixed swatches not rendering properly at product detail page
  • Note: This issue occurs on develop branch.

Screenshots of visual changes before/after (if there are any)

Before:
2019_07_10_Selection_001

After:
2019_07_10_Selection_002

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

src/themes/default/pages/Product.vue Outdated Show resolved Hide resolved
@vishal-7037
Copy link
Contributor Author

vishal-7037 commented Jul 10, 2019

@pkarw , Hello

I've updated suggested changes and added comment for you question.

Can you please check it and let me know.

Thank you.

@vishal-7037
Copy link
Contributor Author

@pkarw,
I've added a condition for undefined also.
Thank you.

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested the changes - the check wasn't covering the potential issues

@vishal-7037
Copy link
Contributor Author

@pkarw, I've updated your suggested changes

@vishal-7037
Copy link
Contributor Author

@pkarw , I'm using magento2-vsbridge-indexer magento extension as an indexer

@pkarw
Copy link
Collaborator

pkarw commented Jul 11, 2019

magento2-vsbridge-indexer fixed to support the labels: vuestorefront/magento2-vsbridge-indexer#83

we can still merge this fix in for backward compatibiltiy

@pkarw pkarw merged commit d3c816b into vuestorefront:develop Jul 13, 2019
@patzick patzick added this to the 1.11.0-rc.1 milestone Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants