-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed swatches not rendering properly at product detail page #3206
Fixed swatches not rendering properly at product detail page #3206
Conversation
@pkarw , Hello I've updated suggested changes and added comment for you question. Can you please check it and let me know. Thank you. |
@pkarw, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested the changes - the check wasn't covering the potential issues
@pkarw, I've updated your suggested changes |
@pkarw , I'm using |
magento2-vsbridge-indexer fixed to support the labels: vuestorefront/magento2-vsbridge-indexer#83 we can still merge this fix in for backward compatibiltiy |
Short description and why it's useful
Screenshots of visual changes before/after (if there are any)
Before:
After:
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance