-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/configurable expire headers for static assets #3289
Merged
patzick
merged 5 commits into
vuestorefront:develop
from
phoenix-bjoern:feature/configurable-expire-headers-for-static-assets
Jul 26, 2019
Merged
Feature/configurable expire headers for static assets #3289
patzick
merged 5 commits into
vuestorefront:develop
from
phoenix-bjoern:feature/configurable-expire-headers-for-static-assets
Jul 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patzick
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature, i've seen that in action :)
lukeromanowicz
suggested changes
Jul 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! one small improvement could be done but overall it's exactly what we need 👍
lukeromanowicz
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#3268
closes #
Short description and why it's useful
Added a new configuration expireHeaders to define max-age per mime type:
"expireHeaders": { "default": "30d", "application/json": "24h", "image/png": "7d" }
If there is no setting for the mime type it uses the default value.
Note that if the NODE_ENV isn't "production" the max-age setting will be 0 (which is helpful during development to not deal with browser cache invalidation). So to test the functionality you should switch to production mode.
Screenshots of visual changes before/after (if there are any)
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance