Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fixing static links #3292

Merged
merged 7 commits into from
Jul 29, 2019

Conversation

MariaKern
Copy link
Contributor

Short description and why it's useful

The static links on the cms elements (banners for example) on homepage are wrong, since the urls of categories changed from "/c/women-20" to "/women/women-20" for example.
This issue is also in the slider and the MinimalFooter and in the banners of the "de" an "it" stores.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@MariaKern MariaKern changed the base branch from master to develop July 26, 2019 13:11
@pspaczek pspaczek added the vs-hackathon Tasks for the Hackathon label Jul 26, 2019
@MariaKern MariaKern marked this pull request as ready for review July 26, 2019 13:30
@lukeromanowicz lukeromanowicz added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jul 27, 2019
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @MariaKern ! :) waiting for more ;D

@patzick patzick added this to the 1.11.0-rc.1 milestone Jul 29, 2019
@patzick patzick merged commit 692d55f into vuestorefront:develop Jul 29, 2019
@alinadivante
Copy link
Collaborator

alinadivante commented Aug 12, 2019

For the "de" and "it" stores - links like "/frauen/frauen-20" doesn't work, I'm redirected to /page-not-found.
I think we should use always women/women-20.
For "de" store it should be → de/women/women-20, for "it" → it/women/women-20

Please, see how links look now for "de"/"it" stores:

  1. Link from sidemenu (and no products found):
    image
  2. Link from banner on homepage (user is redirected to /page-not-found):
    image2
  3. Link from breadcrumbs (user is redirected to /page-not-found):
    image3

@alinadivante alinadivante added QA rejected Testers will add this label when something is still wrong and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Aug 12, 2019
@pkarw
Copy link
Collaborator

pkarw commented Aug 12, 2019

@alinadivante can you please create a new issue out of this one/

@alinadivante
Copy link
Collaborator

No problem. :) And we will close this one ?

@pkarw
Copy link
Collaborator

pkarw commented Aug 12, 2019

this one is closed because it's pull request so I'm afraid we'll lose this issue having it just in the comment

@alinadivante
Copy link
Collaborator

@pkarw I reported it here: #3359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA rejected Testers will add this label when something is still wrong vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants