Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed merge function for typeof array #3311

Merged
merged 3 commits into from
Jul 30, 2019
Merged

Fixed merge function for typeof array #3311

merged 3 commits into from
Jul 30, 2019

Conversation

pspaczek
Copy link
Collaborator

Related issues

closes #

Short description and why it's useful

Screenshots of visual changes before/after (if there are any)

When I copy store inside extendStore I always clone deep do new object. In this case when inside store function finds Array then copy it to object.
Now I added behavior for array and extendStore works greate

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

core/helpers/index.ts Outdated Show resolved Hide resolved
@patzick patzick added this to the 1.11.0-rc.1 milestone Jul 30, 2019
@patzick patzick merged commit f2d587b into vuestorefront:develop Jul 30, 2019
@pspaczek pspaczek deleted the bugfix/extendModule branch September 17, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants