Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix async chain in registering routes #3323

Merged

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Aug 2, 2019

Short description and why it's useful

Should fix a problem with urlDispatcher in some edge cases during SSR load.
@SebSzcze please confirm that it helps.

After confirmation i'll back-port it also to 1.10

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

@patzick patzick added not ready for merge PR is holded. Needs some clarifications or things that need to be finished. QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Aug 2, 2019
@patzick patzick added this to the 1.11.0-rc.1 milestone Aug 2, 2019
@pkarw pkarw merged commit f56113f into vuestorefront:develop Aug 2, 2019
@seSze
Copy link

seSze commented Aug 2, 2019

@patzick I couldn't reproduce the error, so I think this solves the problem

@patzick patzick deleted the bugfix/ssr-problem-with-urldispatcher branch August 8, 2019 12:21
@patzick patzick removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. not ready for merge PR is holded. Needs some clarifications or things that need to be finished. labels Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants