fix invalid route in ButtonOutline #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeromanowicz
force-pushed
the
bugfix/invalid-route-in-buttonoutline
branch
from
bb792c9
to
dfcd668
Compare
patzick
requested changes
Sep 13, 2019
core/lib/multistore.ts
Outdated
| routeObj.path = '/' + storeCode + '/' + (routeObj.path.startsWith('/') ? routeObj.path.slice(1) : routeObj.path) | ||
| } | ||
| } else { | ||
| if (storeCode && config.defaultStoreCode !== storeCode && config.storeViews[storeCode].appendStoreCode) { |
There was a problem hiding this comment.
what if somehow config.storeViews[storeCode] would not exist?
| @@ -1,7 +1,7 @@ | |||
| <template> | |||
| <component | |||
| :is="link ? 'router-link' : 'button'" | |||
| :to="localizedRoute(link)" | |||
| :to="link ? localizedRoute(link) : null" | |||
There was a problem hiding this comment.
i believe we shouldn't direct on users such logic; we're returning here the same object, it's not necessary and overcomplication for newcomers.
patzick
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
followup to #3515