New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring storeCodeFromRoute, resolve store code on SSR #3593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkarw I'm just started with reviewing this PR, it probably will be a conflict as we have modified same file (but not so complicated) so would be nice to merge it beforehand. |
9ba3464
to
b671b12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and mostly moving code, so approving, but would be nice to add unit tests to there methods as for example they would throw an error in case of null param
b671b12
to
e0debde
Compare
Related issues
closes #3576
Short description and why it's useful
It solves the problem when we want to reveal store code on SSR.
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
Contribution and currently important rules acceptance