remove modifing config by reference in multistore #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejewsky
approved these changes
Sep 25, 2019
patzick
requested changes
Sep 25, 2019
CHANGELOG.md
Outdated
| @@ -113,6 +113,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Fixed resolving store code on SSR - @andrzejewsky (#3576) | |||
| - Clear user data if error occurs while login - @gibkigonzo (#3588) | |||
| - Fix loading bestsellers on 404 error page - @andrzejewsky (#3540) | |||
| - Remove modifing config by reference in multistore - @gibkigonzo | |||
There was a problem hiding this comment.
please add PR number if there is no issue for this
Suggested change
| - Remove modifing config by reference in multistore - @gibkigonzo | |
| - Remove modifying config by reference in multistore - @gibkigonzo (#3617) |
core/lib/multistore.ts
Outdated
| storeCode: null, | ||
| storeId: config.defaultStoreCode && config.defaultStoreCode !== '' ? config.storeViews[config.defaultStoreCode].storeId : 1, | ||
| seo: config.seo || {} | ||
| seo: Object.assign({}, config.seo || {}) |
There was a problem hiding this comment.
Suggested change
| seo: Object.assign({}, config.seo || {}) | |
| seo: Object.assign({}, config.seo) |
There was a problem hiding this comment.
done, thanks :)
added 2 commits
September 25, 2019 11:01
…into bugfix/remove-modify-config-in-prepareStoreView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description and why it's useful
it fixes that config is modifying unexpectedly which causes wrong store Id in some cases
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
developbranch and want to merge it back todevelopreleasebranch and want to merge it back toreleasehotfixormasterbranch and want to merge it back tohotfixUpgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and currently important rules acceptance