check silentMode in errors on the same level as task.silent

[gibkigonzo]

Related issues

closes #3621

Short description and why it's useful

with this change silentMode will be checked on the same level as task.silent

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

• Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
• RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
• Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

• No upgrade steps required (100% backward compatibility and no breaking changes)
• I've updated the Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

• I read and followed contribution rules

[andrzejewsky]

I'm not to sure about this jsonRespone.code but let me analyse that 😄

[andrzejewsky]

try with this:

        const hasError = (jsonResponse) => {
          if (typeof jsonResponse.result === 'string') {
            return true
          }

          const hasMessage = jsonResponse.result.result || jsonResponse.result.message

          return hasMessage && jsonResponse.result.code !== 'ENOTFOUND'
        }

        const getErrorMessage = (jsonResponse) => {
          if (typeof jsonResponse.result === 'string') {
            return  jsonResponse.result
          }

          if (typeof jsonResponse.result.result === 'string') {
            return jsonResponse.result.result
          }

          jsonResponse.result.message
        }

        if (!task.silent && jsonResponse.result && hasError(jsonResponse) && !silentMode) {
          rootStore.dispatch('notification/spawnNotification', {
            type: 'error',
            message: i18n.t(getErrorMessage(jsonResponse)),
            action1: { label: i18n.t('OK') }
          })
        }

and put these function on the top of the file, now these conditions will be more readable, feel free to improve that, and please test if it works as previously. Would be nice to move this to the helpers and write some unit test

[gibkigonzo]

@andrzejewsky thanks, I've applied your suggestions :)

[rain2o]

Thanks for the fast reaction everyone! I like the cleanup of the code you did while fixing this. Looks good!