Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass to registerModule all parameters as one object #3634

Merged
merged 2 commits into from
Sep 27, 2019
Merged

pass to registerModule all parameters as one object #3634

merged 2 commits into from
Sep 27, 2019

Conversation

gibkigonzo
Copy link
Collaborator

Short description and why it's useful

Pass to registerModule all parameters as one object to use only needed arguments and easier code maintenance.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@pkarw
Copy link
Collaborator

pkarw commented Sep 27, 2019

How about the backward compoatibility with the modules developed by community? Let's say : https://github.com/Interactivated/vsf-algolia-search/blob/master/index.ts

as far as I see they're using the other/legacy modules api that still should be supported even after this change @filrak?

@pkarw pkarw merged commit f5374ea into vuestorefront:develop Sep 27, 2019
@patzick patzick added this to the 1.11.0-rc.1 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants