Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context implementation #5218

Merged
merged 17 commits into from Nov 25, 2020
Merged

Context implementation #5218

merged 17 commits into from Nov 25, 2020

Conversation

andrzejewsky
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2020

💙 vsf-next-demo successfully deployed at https://4bdc1c25cad8ee87b08e596df86c850e17dfa97e.vsf-next-demo.preview.storefrontcloud.io

const customerSignMeUp = async (draft: CustomerSignMeUpDraft): Promise<SignInResponse> => {
const { locale, acceptLanguage, currentToken, auth, client } = getSettings();
const registerResponse = await client.mutate({
const customerSignMeUp = async (context, draft: CustomerSignMeUpDraft): Promise<SignInResponse> => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why its context on some and settings on others?

Copy link
Collaborator

@filrak filrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need a type for IntegrationContext (then maybe we can call it context instead of settings because the type will differentiate it from nuxt context?

@andrzejewsky andrzejewsky merged commit 131b159 into next Nov 25, 2020
@@ -1,4 +1,6 @@
import defaultConfig from '@vue-storefront/commercetools/nuxt/defaultConfig';
import { createIntegrationPlugin } from '@vue-storefront/core';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'core/nuxtor@vue-storefront/nuxt` ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't work :/ but i need to work on this

@filrak filrak deleted the i-hope-it-works branch March 19, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants