Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next: Mega menu in app header #5283

Merged
merged 23 commits into from Jan 5, 2021

Conversation

lukaszjedrasik
Copy link
Contributor

@lukaszjedrasik lukaszjedrasik commented Dec 3, 2020

Related Issues

closes #5267

Short Description and Why It's Useful

  1. Added MegaMenu
  • fetched top-level root categories
  • seems like something is wrong with storefront UI component SfMegaMenu. Sometimes after page refresh, MegaMenu doesn't want to open. I told Justyna and Adam about it.
  1. Moved AppHeader above layout

Screenshots of Visual Changes before/after (if There Are Any)

Before:

Zrzut ekranu 2020-12-3 o 14 26 51

After:
Zrzut ekranu 2020-12-3 o 14 27 57

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE

  • Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

┆Issue is synchronized with this Jira Story by Unito

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lukaszjedrasik
❌ Łukasz


Łukasz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Apply changes to context to Boilerplate (vuestorefront#5276)
Copy link
Contributor

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case for onlyParents flag and it's ready to merge :D

@lukaszjedrasik lukaszjedrasik changed the title Draft: Mega menu in app header Next: Mega menu in app header Dec 3, 2020
@lukaszjedrasik
Copy link
Contributor Author

@andrzejewsky I have added test case and updated getCategory mock in boilerplate

Copy link
Collaborator

@filrak filrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please use webp instead of png

@andrzejewsky andrzejewsky self-requested a review December 18, 2020 12:10
@andrzejewsky andrzejewsky added the Next Issues/bugs for Vue Storefront Next label Dec 21, 2020
@coveralls
Copy link

coveralls commented Dec 27, 2020

Pull Request Test Coverage Report for Build 446813198

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 94.172%

Totals Coverage Status
Change from base Build 440438848: -0.07%
Covered Lines: 620
Relevant Lines: 653

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 446813198

  • 0 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 95.504%

Totals Coverage Status
Change from base Build 440438848: 1.3%
Covered Lines: 333
Relevant Lines: 341

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 27, 2020

Pull Request Test Coverage Report for Build 463349773

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 94.247%

Totals Coverage Status
Change from base Build 440438848: 0.006%
Covered Lines: 1355
Relevant Lines: 1421

💛 - Coveralls

packages/commercetools/theme/components/TopMenu.vue Outdated Show resolved Hide resolved
packages/commercetools/theme/components/TopMenu.vue Outdated Show resolved Hide resolved
packages/commercetools/theme/components/TopMenu.vue Outdated Show resolved Hide resolved
packages/commercetools/theme/components/TopMenu.vue Outdated Show resolved Hide resolved
packages/commercetools/theme/components/TopMenu.vue Outdated Show resolved Hide resolved
packages/commercetools/theme/components/TopMenu.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@filrak filrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the code again and use getters in places where you call category properties directly

@lukaszjedrasik
Copy link
Contributor Author

I think that now everything should be fine :)

@filrak filrak merged commit f947ada into vuestorefront:next Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants