New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next: Mega menu in app header #5283
Next: Mega menu in app header #5283
Conversation
Łukasz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Apply changes to context to Boilerplate (vuestorefront#5276)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test case for onlyParents
flag and it's ready to merge :D
@andrzejewsky I have added test case and updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please use webp
instead of png
e4e9928
to
52d2ad4
Compare
d8fb380
to
4388a55
Compare
Pull Request Test Coverage Report for Build 446813198
💛 - Coveralls |
Pull Request Test Coverage Report for Build 446813198
💛 - Coveralls |
Pull Request Test Coverage Report for Build 463349773
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the code again and use getters in places where you call category properties directly
I think that now everything should be fine :) |
Related Issues
closes #5267
Short Description and Why It's Useful
SfMegaMenu
. Sometimes after page refresh, MegaMenu doesn't want to open. I told Justyna and Adam about it.AppHeader
above layoutScreenshots of Visual Changes before/after (if There Are Any)
Before:
After:
Which Environment This Relates To
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE
CHANGELOG.md
with description of your changeContribution and Currently Important Rules Acceptance
┆Issue is synchronized with this Jira Story by Unito