Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy loading and hydration #5326

Merged
merged 11 commits into from
Dec 23, 2020
Merged

Conversation

filipsobol
Copy link
Contributor

@filipsobol filipsobol commented Dec 15, 2020

Short Description and Why It's Useful

Add lazy loading and hydration to improve performance.

Which Environment This Relates To

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2020

💙 vsf-next-demo successfully deployed at https://7be11c7229673432b9605096d8e88b9b9b6bb432.vsf-next-demo.preview.storefrontcloud.io

@filipsobol filipsobol linked an issue Dec 15, 2020 that may be closed by this pull request
@filipsobol filipsobol added the Next Issues/bugs for Vue Storefront Next label Dec 16, 2020
Copy link
Contributor

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, but please wait until fixes in SFUI will be merged - we can compare then what has changed / improved

@coveralls
Copy link

coveralls commented Dec 22, 2020

Pull Request Test Coverage Report for Build 438031861

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.241%

Totals Coverage Status
Change from base Build 436132113: 0.0%
Covered Lines: 1353
Relevant Lines: 1419

💛 - Coveralls

Copy link
Contributor

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, please update changelog

@filrak filrak merged commit 3eaf767 into next Dec 23, 2020
@filrak filrak deleted the 20201211-reduce-total-blocking-time branch March 19, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyze long TBT
5 participants