-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lazy loading and hydration #5326
Conversation
💙 vsf-next-demo successfully deployed at https://7be11c7229673432b9605096d8e88b9b9b6bb432.vsf-next-demo.preview.storefrontcloud.io |
packages/core/nuxt-theme-module/theme/components/CartSidebar.vue
Outdated
Show resolved
Hide resolved
packages/core/nuxt-theme-module/theme/components/LoginModal.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, but please wait until fixes in SFUI will be merged - we can compare then what has changed / improved
packages/core/nuxt-theme-module/theme/components/CartSidebar.vue
Outdated
Show resolved
Hide resolved
packages/core/nuxt-theme-module/theme/components/CartSidebar.vue
Outdated
Show resolved
Hide resolved
packages/core/nuxt-theme-module/theme/components/LoginModal.vue
Outdated
Show resolved
Hide resolved
packages/core/nuxt-theme-module/theme/components/CartSidebar.vue
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 438031861Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, please update changelog
Short Description and Why It's Useful
Add lazy loading and hydration to improve performance.
Which Environment This Relates To
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog