Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme docs + minor polishments #5360

Merged
merged 13 commits into from
Jan 7, 2021
Merged

Theme docs + minor polishments #5360

merged 13 commits into from
Jan 7, 2021

Conversation

filrak
Copy link
Collaborator

@filrak filrak commented Dec 30, 2020

Related Issues

Short Description and Why It's Useful

  • Created a guide tab according toour planned table of contents
  • Added Theme documentation
  • Removed nuxt modules that are already installed by vsf nuxt modules from theme
  • Added more information to the intro doc
  • Added yarn/npm installation
  • Change composables in Key Concepts to list with links and short explainations
  • Added App context to Key Concepts
  • Rewritten the i18n doc and changed to internationalization

@filrak filrak added the Next Issues/bugs for Vue Storefront Next label Dec 30, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2020

💙 vsf-next-demo successfully deployed at https://06defeebf4c2599eb1180b83c132e2d72399c321.vsf-next-demo.preview.storefrontcloud.io

@vuestorefront vuestorefront deleted a comment from coveralls Dec 30, 2020
@vuestorefront vuestorefront deleted a comment from coveralls Dec 30, 2020
@vuestorefront vuestorefront deleted a comment from coveralls Dec 30, 2020

Headless eCommerce frontends are complex and devloping them can take a lot of time.

**Solution** With Vue Storefront you're getting a working headless frontend connected to eCommerce, CMS and other third-party services of your choice out of the box along with a hundreds of ready-to-use Vue Storefront and Nuxt modules for all common functionalities! Because of that you're saving hundreds (or even thousands) of working hours so you can focus more on details and polishments while leaving the heavy lifting to us!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe dozens of ready-to-use... instead of hundreds as we won't have hundreds that soon and you used hunderds word in the next sentence?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of working hours so you can focus more on details -> of working hours and focus mostly on details. Wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devloping > developing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polishments > polishing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fifciu I refer to nuxt modules as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw @ThermScissorpunch and @Fifciu please use suggestions feature for such stuff - it is much easier to apply them.

Also thanks for comments ;)

packages/core/docs/README.md Outdated Show resolved Hide resolved
<code-group>
<code-block title="YARN">
```bash
yarn global add @vue-storefront/cli@next
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should cover the case when someone already has VSF1 CLI installed globally. Many VSF1 Devs will try VSF Next and get confused at the beginning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

packages/core/docs/general/key-concepts.md Show resolved Hide resolved
packages/core/docs/general/key-concepts.md Outdated Show resolved Hide resolved
packages/core/docs/README.md Outdated Show resolved Hide resolved
packages/core/docs/README.md Outdated Show resolved Hide resolved
packages/core/docs/README.md Outdated Show resolved Hide resolved
packages/core/docs/guide/internationalization.md Outdated Show resolved Hide resolved
packages/core/docs/guide/internationalization.md Outdated Show resolved Hide resolved
packages/core/docs/guide/internationalization.md Outdated Show resolved Hide resolved
packages/core/docs/guide/theme.md Outdated Show resolved Hide resolved
filrak and others added 6 commits January 4, 2021 13:25
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
packages/core/docs/README.md Outdated Show resolved Hide resolved
packages/core/docs/README.md Outdated Show resolved Hide resolved
@filrak filrak merged commit b7cf712 into next Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants