Bug/infinite loading #5643
Merged
Bug/infinite loading #5643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💙 vsf-next-demo successfully deployed at https://bbfdaa6a314d153caac78a67b40a7a65950bf07d.vsf-next-demo.preview.storefrontcloud.io |
Pull Request Test Coverage Report for Build 675572243Details
💛 - Coveralls |
Baroshem
force-pushed
the
bug/infinite-loading
branch
from
fdff101
to
992c627
Compare
This was referenced Mar 16, 2021
Baroshem
force-pushed
the
bug/infinite-loading
branch
from
992c627
to
04ca18c
Compare
andrzejewsky
suggested changes
Mar 22, 2021
| @@ -63,7 +64,7 @@ export const useUserFactory = <USER, UPDATE_USER_PARAMS, REGISTER_USER_PARAMS ex | |||
| user.value = await _factoryParams.register(providedUser); | |||
| error.value.register = null; | |||
| } catch (err) { | |||
| error.value.register = err; | |||
| error.value.register = err.response?.data || err; | |||
There was a problem hiding this comment.
just err - you can't assume graphql in the core
Baroshem
force-pushed
the
bug/infinite-loading
branch
from
94d5a3b
to
2de98c9
Compare
andrzejewsky
suggested changes
Mar 22, 2021
| if (hasUserErrors) { | ||
| error.login = userError.value.login; | ||
| error.register = userError.value.register; | ||
| const loginGraphQLErrorMessage = loginGraphQLError?.graphQLErrors[0]?.message; |
There was a problem hiding this comment.
same here - this is core template
There was a problem hiding this comment.
Moved error handling CT integration
filrak
approved these changes
Mar 25, 2021
andrzejewsky
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
closes #5508
closes #5463
Short Description of the PR
Fixed problem with infinite loading caused by not having error handing in core/middleware. By implementing try catch, and throwing more accurate error in useUserFactory, now LoginModal is not closing after incorrect register/login attempt and it shows appropriate error. It also allowed to fix another problem related to empty shipping method when there was no shipping methods available.
Screenshots of Visual Changes before/after (if There Are Any)
Pull Request Checklist