Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove helpers/filters from nuxt-theme and commercetools #5669

Merged
merged 2 commits into from Mar 19, 2021

Conversation

k-malkowski
Copy link

@k-malkowski k-malkowski commented Mar 16, 2021

Related Issues

closes #5620

Short Description of the PR

Removed helpers/filters from @vue-storefront/nuxt-theme and @vue-storefront/commercetools-theme because they are useless now.

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Mar 16, 2021

Pull Request Test Coverage Report for Build 658925659

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.6%) to 85.071%

Totals Coverage Status
Change from base Build 656941134: 4.6%
Covered Lines: 815
Relevant Lines: 944

💛 - Coveralls

@filrak filrak requested a review from filipsobol March 16, 2021 20:49
@coveralls
Copy link

coveralls commented Mar 16, 2021

Pull Request Test Coverage Report for Build 665020090

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 80.121%

Files with Coverage Reduction New Missed Lines %
packages/commercetools/api-client/src/helpers/commercetoolsLink/linkHandlers.ts 1 90.63%
packages/core/cli/src/scripts/generateTemplates/index.ts 6 0%
Totals Coverage Status
Change from base Build 656941134: -0.4%
Covered Lines: 1503
Relevant Lines: 1747

💛 - Coveralls

@filipsobol filipsobol added commercetools Next Issues/bugs for Vue Storefront Next labels Mar 18, 2021
@k-malkowski
Copy link
Author

The documentation (next) has been already updated, so I think everything is good now. What about this error in deploy PR? @filipsobol

Copy link
Contributor

@filipsobol filipsobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation (next) has been already updated, so I think everything is good now. What about this error in deploy PR? @filipsobol

Can you add a changelog, please? https://docs.vuestorefront.io/v2/contributing/creating-changelog.html

@filrak
Copy link
Collaborator

filrak commented Mar 19, 2021

Thanks, merging!

@filrak filrak merged commit 36304ce into vuestorefront:next Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commercetools Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants