New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next: Mega menu for desktop/mobile #5685
Conversation
Pull Request Test Coverage Report for Build 675872606
💛 - Coveralls |
Pull Request Test Coverage Report for Build 710841566Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
💙 vsf-next-demo successfully deployed at https://015851b6bf211c3d4b471cfdc2c5e9f1001564a5.vsf-next-demo.preview.storefrontcloud.io |
5c606f2
to
e78b9c0
Compare
packages/core/nuxt-theme-module/theme/components/Header/HeaderNav.vue
Outdated
Show resolved
Hide resolved
e78b9c0
to
3fab5a0
Compare
b018126
to
92a6d7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have copy-pasted files with small differences between them. Please create some of common logic that can be reused. I understand that you copy-pasted something from core to integration, but you cannot copy-paste files inside of one domain (core / integration)
2063c68
to
afda0b1
Compare
71b2444
to
efa3fb5
Compare
0d8f74b
to
f5678d3
Compare
This is closed due to inactivity. If you want your PR to be re-opened, please update your files, check for any conflicts. If your PR is for Vue Storefront 1 target the new repository at https://github.com/vuestorefront/vue-storefront-1 |
Related Issues
closes #5267
Screenshots of Visual Changes before/after (if There Are Any)
Nagranie.z.ekranu.2021-03-22.o.10.21.31.mp4
Pull Request Checklist