Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next: Mega menu for desktop/mobile #5685

Closed
wants to merge 41 commits into from
Closed

Conversation

lukaszjedrasik
Copy link
Contributor

@lukaszjedrasik lukaszjedrasik commented Mar 22, 2021

Related Issues

closes #5267

Screenshots of Visual Changes before/after (if There Are Any)

Nagranie.z.ekranu.2021-03-22.o.10.21.31.mp4

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues

@coveralls
Copy link

coveralls commented Mar 22, 2021

Pull Request Test Coverage Report for Build 675872606

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.3%) to 84.419%

Totals Coverage Status
Change from base Build 667588630: 4.3%
Covered Lines: 813
Relevant Lines: 948

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 22, 2021

Pull Request Test Coverage Report for Build 710841566

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.596%

Totals Coverage Status
Change from base Build 708759855: 0.0%
Covered Lines: 1506
Relevant Lines: 1755

💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2021

💙 vsf-next-demo successfully deployed at https://015851b6bf211c3d4b471cfdc2c5e9f1001564a5.vsf-next-demo.preview.storefrontcloud.io

@sync-by-unito sync-by-unito bot mentioned this pull request Mar 22, 2021
@lukaszjedrasik lukaszjedrasik added the Next Issues/bugs for Vue Storefront Next label Mar 22, 2021
@lukaszjedrasik lukaszjedrasik force-pushed the mega-menu-desktop branch 5 times, most recently from 5c606f2 to e78b9c0 Compare March 30, 2021 05:59
Copy link
Contributor

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have copy-pasted files with small differences between them. Please create some of common logic that can be reused. I understand that you copy-pasted something from core to integration, but you cannot copy-paste files inside of one domain (core / integration)

@lukaszjedrasik lukaszjedrasik changed the title Next: Mega menu in app header Next: Mega menu for desktop/mobile Jun 24, 2021
@bloodf
Copy link
Contributor

bloodf commented Aug 31, 2021

This is closed due to inactivity.

If you want your PR to be re-opened, please update your files, check for any conflicts.

If your PR is for Vue Storefront 1 target the new repository at https://github.com/vuestorefront/vue-storefront-1

@bloodf bloodf closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boilerplate commercetools core Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MegaMenu to theme
7 participants