Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product attribute mapping #5708

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Conversation

filipsobol
Copy link
Contributor

Related Issues

Fix mapping for product attributes with type set

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have followed naming conventions

@filipsobol filipsobol added commercetools Next Issues/bugs for Vue Storefront Next bug Bug reports labels Mar 25, 2021
@coveralls
Copy link

coveralls commented Mar 25, 2021

Pull Request Test Coverage Report for Build 686778103

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.121%

Totals Coverage Status
Change from base Build 686251374: 0.0%
Covered Lines: 1502
Relevant Lines: 1746

💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2021

💙 vsf-next-demo successfully deployed at https://befbab77b942571fcf72881e47e0a791d2094f15.vsf-next-demo.preview.storefrontcloud.io

@filipsobol filipsobol merged commit cdcadc4 into next Mar 26, 2021
@filipsobol filipsobol deleted the 20210325-fix-product-attribute-mapping branch March 30, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports commercetools Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants