Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search adjusted to EE #5709

Merged
merged 6 commits into from Apr 9, 2021
Merged

Search adjusted to EE #5709

merged 6 commits into from Apr 9, 2021

Conversation

justyna-13
Copy link
Contributor

@justyna-13 justyna-13 commented Mar 25, 2021

Related Issues

related https://github.com/vuestorefront/enterprise-packages/pull/78

Short Description of the PR

Screenshots of Visual Changes before/after (if There Are Any)

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues

@justyna-13 justyna-13 added the Next Issues/bugs for Vue Storefront Next label Mar 25, 2021
@coveralls
Copy link

coveralls commented Mar 25, 2021

Pull Request Test Coverage Report for Build 686894115

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.3%) to 84.419%

Totals Coverage Status
Change from base Build 686251374: 4.3%
Covered Lines: 813
Relevant Lines: 948

💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2021

💙 vsf-next-demo successfully deployed at https://8372330e26200ae39a678784aea29c34cb321b35.vsf-next-demo.preview.storefrontcloud.io

@coveralls
Copy link

coveralls commented Mar 25, 2021

Pull Request Test Coverage Report for Build 721394472

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.5%) to 77.085%

Totals Coverage Status
Change from base Build 708759855: -2.5%
Covered Lines: 1985
Relevant Lines: 2343

💛 - Coveralls

@justyna-13 justyna-13 changed the title [WIP] Search adjusted to EE Search adjusted to EE Mar 26, 2021
@@ -129,7 +129,7 @@ export default {
const { isAuthenticated, load: loadUser } = useUser();
const { cart, load: loadCart } = useCart();
const { load: loadWishlist } = useWishlist();
const term = ref(getFacetsFromURL().term);
const term = ref(getFacetsFromURL().phrase);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can't assume it, it's a platform--specific field

@justyna-13 justyna-13 merged commit c110e43 into next Apr 9, 2021
@justyna-13 justyna-13 deleted the search-adjust-to-ee branch April 9, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants