Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to product in CartSidebar #5728

Closed

Conversation

igorwojciechowski
Copy link
Contributor

Related Issues

closes #5726

Short Description of the PR

Adds link to product page in CartSidebar

Screenshots of Visual Changes before/after (if There Are Any)

N/A

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2021

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Apr 6, 2021

Pull Request Test Coverage Report for Build 721561761

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.4%) to 84.031%

Totals Coverage Status
Change from base Build 708759855: 4.4%
Covered Lines: 817
Relevant Lines: 956

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 721561761

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.0%) to 64.599%

Totals Coverage Status
Change from base Build 708759855: -15.0%
Covered Lines: 308
Relevant Lines: 386

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 6, 2021

Pull Request Test Coverage Report for Build 721561761

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.2%) to 77.441%

Totals Coverage Status
Change from base Build 708759855: -2.2%
Covered Lines: 2026
Relevant Lines: 2384

💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021

💙 vsf-next-demo successfully deployed at https://8ee3c04b0a6d255b81ae07311ed5d5195f93bd24.vsf-next-demo.preview.storefrontcloud.io

@igorwojciechowski igorwojciechowski marked this pull request as ready for review April 6, 2021 06:40
@igorwojciechowski igorwojciechowski added the Next Issues/bugs for Vue Storefront Next label Apr 13, 2021
Copy link
Contributor

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok according to our agreements, please create an RFC first with the proposal for a new getters in the core, link this PR, and one RFC is confirmed we can merge it

module.exports = {
description: 'added link to product page in CartSidebar',
link: 'https://github.com/vuestorefront/vue-storefront/issues/5726',
isBreaking: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually might be kinda breaking, as it updates nuxt-theme template and enforce adding getter in other integrations.

@bloodf
Copy link
Contributor

bloodf commented Aug 31, 2021

This is closed due to inactivity.

If you want your PR to be re-opened, please update your files, check for any conflicts.

If your PR is for Vue Storefront 1 target the new repository at https://github.com/vuestorefront/vue-storefront-1

@bloodf bloodf closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to product details page on cart sidebar
5 participants