New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to product in CartSidebar #5728
Conversation
Pull Request Test Coverage Report for Build 721561761
💛 - Coveralls |
Pull Request Test Coverage Report for Build 721561761
💛 - Coveralls |
Pull Request Test Coverage Report for Build 721561761
💛 - Coveralls |
💙 vsf-next-demo successfully deployed at https://8ee3c04b0a6d255b81ae07311ed5d5195f93bd24.vsf-next-demo.preview.storefrontcloud.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok according to our agreements, please create an RFC first with the proposal for a new getters in the core, link this PR, and one RFC is confirmed we can merge it
module.exports = { | ||
description: 'added link to product page in CartSidebar', | ||
link: 'https://github.com/vuestorefront/vue-storefront/issues/5726', | ||
isBreaking: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually might be kinda breaking, as it updates nuxt-theme template and enforce adding getter in other integrations.
This is closed due to inactivity. If you want your PR to be re-opened, please update your files, check for any conflicts. If your PR is for Vue Storefront 1 target the new repository at https://github.com/vuestorefront/vue-storefront-1 |
Related Issues
closes #5726
Short Description of the PR
Adds link to product page in CartSidebar
Screenshots of Visual Changes before/after (if There Are Any)
N/A
Pull Request Checklist