Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mg2 cli patch 4.1.0 #6903

Merged
merged 3 commits into from
Apr 6, 2023
Merged

feat: mg2 cli patch 4.1.0 #6903

merged 3 commits into from
Apr 6, 2023

Conversation

skirianov
Copy link
Contributor

Changes as per issue #6899 and #6902

  • Add logging for whole CLI process
  • Fixed CLI without Magento 2 local installation
  • Add suggested name for Magento directory
  • Check and compare Magento dir name and VSF project dir name
  • Add instructions to cd into project name
  • Add yarn version check

Description

Related Issue

#6899 #6902

Motivation and Context

Imporve overall DX and fix bug

How Has This Been Tested?

Manual QA

Screenshots:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I tested manually my code, and it works well with both:

  • Default Theme
  • Capybara Theme

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@skirianov skirianov requested a review from Igloczek April 4, 2023 11:59
@github-actions github-actions bot added the cli label Apr 4, 2023
@skirianov skirianov requested a review from a team April 4, 2023 12:00
@skirianov skirianov changed the title Mg2 cli patch 4.1.0 feat: mg2 cli patch 4.1.0 Apr 4, 2023
@skirianov skirianov merged commit 9bdc22e into main Apr 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants