Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in error message when response has 4xx error code #7100

Merged
merged 1 commit into from
May 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/moody-experts-pump.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@vue-storefront/middleware": patch
---

- **[CHANGED]** Fix typo in default error handler
Now the default error message for error responses bearing a 4xx status code will be
"Request failed with status code ${status}" instead of "Request faileds [...]".
2 changes: 1 addition & 1 deletion packages/middleware/src/errors/defaultErrorHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const defaultErrorHandler = (
res.status(status);
if (status < 500) {
const errMsg =
error?.message ?? `Request faileds with status code ${status}`;
error?.message ?? `Request failed with status code ${status}`;
/**
* For all 4xx error codes or client error codes we wanted to send the error message
*/
Expand Down
Loading