Skip to content

Commit

Permalink
fix: add warning when used with asset modules
Browse files Browse the repository at this point in the history
https://webpack.js.org/guides/asset-modules/

Pushing loaders to asset modules causes them to silently fail
  • Loading branch information
KaelWD committed Feb 5, 2021
1 parent 842595b commit d5446df
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions lib/plugin.js
Expand Up @@ -34,10 +34,18 @@ class VuetifyLoaderPlugin {
resource.query === resourceQuery &&
['.png', '.jpg', '.jpeg', '.webp', '.gif'].includes(path.extname(resource.pathname))
) {
module.loaders.unshift({
loader: require.resolve('vuetify-loader/progressive-loader'),
options
})
if (/^asset\/?/.test(module.type)) {
compilation.errors.push(new Error(
'vuetify-loader: progressiveImages does not work with asset modules, use file-loader or url-loader\n' +
`"${module.rawRequest}" will be loaded normally\n` +
'See https://webpack.js.org/guides/asset-modules/'
))
} else {
module.loaders.unshift({
loader: require.resolve('vuetify-loader/progressive-loader'),
options
})
}
}
})
})
Expand Down

0 comments on commit d5446df

Please sign in to comment.