Skip to content

Commit

Permalink
docs: fix promoted initial layout shift
Browse files Browse the repository at this point in the history
  • Loading branch information
johnleider committed May 1, 2023
1 parent 10b51a4 commit 283f33f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
7 changes: 5 additions & 2 deletions packages/docs/src/components/promoted/Base.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<template>
<v-lazy :min-height="minHeight">
<v-lazy
:min-height="minHeight"
class="d-flex mb-4"
>
<v-sheet
v-bind="$attrs"
:color="isDark ? '#1F1F1F' : 'grey-lighten-4'"
Expand Down Expand Up @@ -33,7 +36,7 @@
const minHeight = computed(() => {
if (props.minHeight) return props.minHeight
if (props.density === 'compact') return 52
if (props.density === 'compact') return 56
if (props.density === 'comfortable') return 74
return 118
Expand Down
1 change: 0 additions & 1 deletion packages/docs/src/components/promoted/Carbon.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<promoted-base
ref="script"
:class="[
'mb-4',
isDark ? 'theme--dark' : 'theme--light',
]"
border
Expand Down
3 changes: 1 addition & 2 deletions packages/docs/src/components/promoted/Promoted.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<a
v-if="ad"
class="d-block mb-4"
class="d-block"
style="max-width: 640px;"
v-bind="attrs"
@click="onClick"
Expand All @@ -13,7 +13,6 @@
max-width="640"
outlined
>

<v-img
:src="background"
class="flex-1-1-auto rounded"
Expand Down

0 comments on commit 283f33f

Please sign in to comment.