fix(VRadioGroup): remove multiple prop (#15910)

fixes #15559
vuetifyjs · Oct 17, 2022 · 32cb6ba · 32cb6ba
1 parent dc496a4
commit 32cb6ba
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/packages/vuetify/src/components/VRadioGroup/VRadioGroup.tsx b/packages/vuetify/src/components/VRadioGroup/VRadioGroup.tsx
@@ -14,7 +14,7 @@ import { useProxiedModel } from '@/composables/proxiedModel'
 
 // Utilities
 import { computed, toRef } from 'vue'
-import { defineComponent, filterInputAttrs, getUid, useRender } from '@/util'
+import { defineComponent, excludeProps, filterInputAttrs, getUid, useRender } from '@/util'
 
 export const VRadioGroup = defineComponent({
   name: 'VRadioGroup',
@@ -28,7 +28,7 @@ export const VRadioGroup = defineComponent({
     },
 
     ...makeVInputProps(),
-    ...makeSelectionControlProps(),
+    ...excludeProps(makeSelectionControlProps(), ['multiple']),
 
     trueIcon: {
       type: IconValue,
@@ -63,7 +63,10 @@ export const VRadioGroup = defineComponent({
     useRender(() => {
       const [inputAttrs, controlAttrs] = filterInputAttrs(attrs)
       const [inputProps, _1] = filterInputProps(props)
-      const [controlProps, _2] = filterControlProps(props)
+      const [controlProps, _2] = filterControlProps({
+        ...props,
+        multiple: false as const,
+      })
       const label = slots.label
         ? slots.label({
           label: props.label,

diff --git a/packages/vuetify/src/util/__tests__/propsFactory.spec.ts b/packages/vuetify/src/util/__tests__/propsFactory.spec.ts
@@ -1,4 +1,4 @@
-import { propsFactory } from '../propsFactory'
+import { excludeProps, propsFactory } from '../propsFactory'
 import { describe, expect, it } from '@jest/globals'
 
 describe('propsFactory', () => {
@@ -30,4 +30,13 @@ describe('propsFactory', () => {
       propsFactory({ foo: definition }, source)()
     ).toStrictEqual({ foo: result })
   })
+
+  it('should remove excluded props', () => {
+    const props = propsFactory({ foo: String, bar: Number })()
+
+    // @ts-expect-error
+    excludeProps(props, ['baz'])
+
+    expect(excludeProps(props, ['foo'])).toStrictEqual({ bar: { type: Number } })
+  })
 })
diff --git a/packages/vuetify/src/util/propsFactory.ts b/packages/vuetify/src/util/propsFactory.ts
@@ -54,6 +54,17 @@ export function propsFactory<
   }
 }
 
+export function excludeProps<
+  PropsOptions extends ComponentObjectPropsOptions,
+  ExcludeProps extends keyof PropsOptions
+> (props: PropsOptions, exclude: ExcludeProps[]): Omit<PropsOptions, ExcludeProps> {
+  const clone = { ...props }
+
+  exclude.forEach(prop => delete clone[prop])
+
+  return clone
+}
+
 type AppendDefault<T extends ComponentObjectPropsOptions, D extends PartialKeys<T>> = {
   [P in keyof T]-?: unknown extends D[P]
     ? T[P]