fix(VSparkline): remove duplicate id (#11262)

vuetifyjs · Apr 30, 2020 · 4a785ff · 4a785ff
1 parent c55d9c6
commit 4a785ff
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 23 deletions.
diff --git a/packages/vuetify/src/components/VSparkline/VSparkline.ts b/packages/vuetify/src/components/VSparkline/VSparkline.ts
@@ -307,7 +307,6 @@ export default mixins<options &
 
       return this.$createElement('path', {
         attrs: {
-          id: this._uid,
           d: genPath(points, this._radius, this.fill, this.parsedHeight),
           fill: this.fill ? `url(#${this._uid})` : 'none',
           stroke: this.fill ? 'none' : `url(#${this._uid})`,

diff --git a/packages/vuetify/src/components/VSparkline/__tests__/__snapshots__/VSparkline.spec.ts.snap b/packages/vuetify/src/components/VSparkline/__tests__/__snapshots__/VSparkline.spec.ts.snap
@@ -39,8 +39,7 @@ exports[`VSparkline.ts should position labels correctly 1`] = `
       42
     </text>
   </g>
-  <path id="35"
-        d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
+  <path d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
         fill="none"
         stroke="url(#35)"
   >
@@ -67,8 +66,7 @@ exports[`VSparkline.ts should render component and match a snapshot 1`] = `
       </stop>
     </linearGradient>
   </defs>
-  <path id="1"
-        d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
+  <path d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
         fill="none"
         stroke="url(#1)"
   >
@@ -759,8 +757,7 @@ exports[`VSparkline.ts should render component with gradient and match a snapsho
       </stop>
     </linearGradient>
   </defs>
-  <path id="9"
-        d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
+  <path d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
         fill="none"
         stroke="url(#9)"
   >
@@ -807,8 +804,7 @@ exports[`VSparkline.ts should render component with label size and match a snaps
       42
     </text>
   </g>
-  <path id="33"
-        d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
+  <path d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
         fill="none"
         stroke="url(#33)"
   >
@@ -835,8 +831,7 @@ exports[`VSparkline.ts should render component with line width and match a snaps
       </stop>
     </linearGradient>
   </defs>
-  <path id="7"
-        d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
+  <path d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
         fill="none"
         stroke="url(#7)"
   >
@@ -863,8 +858,7 @@ exports[`VSparkline.ts should render component with padding and match a snapshot
       </stop>
     </linearGradient>
   </defs>
-  <path id="3"
-        d="M20 54.99999L150 49.8780487804878S150 49.8780487804878 150 49.8780487804878L280 20.00001"
+  <path d="M20 54.99999L150 49.8780487804878S150 49.8780487804878 150 49.8780487804878L280 20.00001"
         fill="none"
         stroke="url(#3)"
   >
@@ -911,8 +905,7 @@ exports[`VSparkline.ts should render component with string labels and match a sn
       42
     </text>
   </g>
-  <path id="11"
-        d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
+  <path d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
         fill="none"
         stroke="url(#11)"
   >
@@ -959,8 +952,7 @@ exports[`VSparkline.ts should render component with string labels and match a sn
       43
     </text>
   </g>
-  <path id="11"
-        d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
+  <path d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
         fill="none"
         stroke="url(#11)"
   >
@@ -1007,8 +999,7 @@ exports[`VSparkline.ts should render component with string labels and match a sn
       baz
     </text>
   </g>
-  <path id="11"
-        d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
+  <path d="M8 66.99999L150 58.36585365853659S150 58.36585365853659 150 58.36585365853659L292 8.00001"
         fill="none"
         stroke="url(#11)"
   >
@@ -1035,8 +1026,7 @@ exports[`VSparkline.ts should render component with trend and equal values and m
       </stop>
     </linearGradient>
   </defs>
-  <path id="31"
-        d="M8 66.99999L150 67L292 67.00001"
+  <path d="M8 66.99999L150 67L292 67.00001"
         fill="none"
         stroke="url(#31)"
   >
@@ -1063,8 +1053,7 @@ exports[`VSparkline.ts should render smooth component and match a snapshot 1`] =
       </stop>
     </linearGradient>
   </defs>
-  <path id="5"
-        d="M8 66.99999L130.03686879378304 59.579687437670394S150 58.36585365853659 168.8494438621337 51.6801625133916L292 8.00001"
+  <path d="M8 66.99999L130.03686879378304 59.579687437670394S150 58.36585365853659 168.8494438621337 51.6801625133916L292 8.00001"
         fill="none"
         stroke="url(#5)"
   >