revert "fix(VCheckbox): add for attribute on checkbox's related lab…

…el (#6179)" This reverts commit 86077df.
vuetifyjs · Feb 4, 2019 · 666e0fc · 666e0fc
1 parent f19a207
commit 666e0fc
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 30 deletions.
diff --git a/packages/vuetify/src/components/VInput/VInput.ts b/packages/vuetify/src/components/VInput/VInput.ts
@@ -53,10 +53,6 @@ export default mixins<options &
     height: [Number, String],
     hideDetails: Boolean,
     hint: String,
-    id: {
-      type: String,
-      required: false
-    },
     label: String,
     loading: Boolean,
     persistentHint: Boolean,
@@ -231,7 +227,7 @@ export default mixins<options &
           color: this.validationState,
           dark: this.dark,
           focused: this.hasState,
-          for: this.$attrs.id || this.id,
+          for: this.$attrs.id,
           light: this.light
         }
       }, this.$slots.label || this.label)

diff --git a/packages/vuetify/test/unit/components/VCheckbox/VCheckbox.spec.js b/packages/vuetify/test/unit/components/VCheckbox/VCheckbox.spec.js
@@ -367,29 +367,4 @@ test('VCheckbox.js', ({ mount }) => {
 
     expect(input.html()).toMatchSnapshot()
   })
-
-  it('should add `for` attribute to label', () => {
-    const wrapper = mount(VCheckbox, {
-      attachToDocument: true,
-      propsData: {
-        id: 'foo',
-        label: 'bar'
-      }
-    })
-
-    const label = wrapper.first('.v-label')
-
-    expect(label.element.getAttribute('for')).toBe('foo')
-
-    const wrapper2 = mount(VCheckbox, {
-      attachToDocument: true,
-      propsData: {
-        label: 'bar'
-      }
-    })
-
-    const label2 = wrapper2.first('.v-label')
-
-    expect(label2.element.getAttribute('for')).toBe(null)
-  })
 })