fix(stackable): move stack classes to explicit values

fixes #5141
vuetifyjs · Mar 10, 2019 · 7dad5e9 · 7dad5e9
1 parent 52ef1af
commit 7dad5e9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/vuetify/src/components/VDialog/VDialog.js b/packages/vuetify/src/components/VDialog/VDialog.js
@@ -64,7 +64,6 @@ export default {
     return {
       animate: false,
       animateTimeout: null,
-      stackClass: 'v-dialog__content--active',
       stackMinZIndex: 200
     }
   },

diff --git a/packages/vuetify/src/mixins/menuable.js b/packages/vuetify/src/mixins/menuable.js
@@ -100,7 +100,6 @@ export default Vue.extend({
     isContentActive: false,
     pageWidth: 0,
     pageYOffset: 0,
-    stackClass: 'v-menu__content--active',
     stackMinZIndex: 6
   }),
 

diff --git a/packages/vuetify/src/mixins/stackable.ts b/packages/vuetify/src/mixins/stackable.ts
@@ -14,7 +14,6 @@ export default Vue.extend<options>().extend({
 
   data () {
     return {
-      stackClass: 'unpecified',
       stackElement: null as Element | null,
       stackExclude: null as Element[] | null,
       stackMinZIndex: 0,
@@ -48,7 +47,10 @@ export default Vue.extend<options>().extend({
       // Convert the NodeList to an array to
       // prevent an Edge bug with Symbol.iterator
       // https://github.com/vuetifyjs/vuetify/issues/2146
-      const activeElements = [...document.getElementsByClassName(this.stackClass)]
+      const activeElements = [
+        ...document.getElementsByClassName('v-menu__content--active'),
+        ...document.getElementsByClassName('v-dialog__content--active')
+      ]
 
       // Get z-index for all active dialogs
       for (let index = 0; index < activeElements.length; index++) {