Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] v-menu appears behind v-dialog in Safari when a v-toolbar is involved #5141

Closed
medeman opened this issue Sep 21, 2018 · 2 comments
Assignees
Labels
C: VMenu VMenu platform specific The issue only occurs on a specific platform

Comments

@medeman
Copy link

medeman commented Sep 21, 2018

The <v-menu> appears behind the <v-dialog> if it is inside a <v-toolbar>.

Versions and Environment

Vuetify: 1.2.4
Vue: 2.5.17
Browsers: Safari
OS: macOS 10.13 / iOS 11.4 / iOS 12.0

Steps to reproduce

After the Codepen has loaded, click on the filter button in the dialog.

Expected Behavior

The <v-menu> should appear in front of the <v-dialog>.

Actual Behavior

In Safari on macOS and iOS, the <v-menu> appears behind the <v-dialog> and the overlay.

Reproduction Link

https://codepen.io/anon/pen/qMvXaX


Additional Comments:

This has to do with the getZIndex() function from the util/helpers.ts file. It returns 0 as z-index because the <nav> element from the <v-toolbar> has a computed z-index of 0 on Safari for some reason.

This issue is probably related to #2111. Pull request #3639 helps, but it doesn't work when a <v-toolbar> is involved since <nav> still has a computed z-index of 0.

This issue doesn't occur in Chrome or Firefox.

@jacekkarczmarczyk jacekkarczmarczyk added the platform specific The issue only occurs on a specific platform label Oct 25, 2018
@MajesticPotatoe MajesticPotatoe changed the title v-menu appears behind v-dialog in Safari when a v-toolbar is involved [Bug Report] v-menu appears behind v-dialog in Safari when a v-toolbar is involved Dec 7, 2018
@johnleider johnleider added this to the v2.0.0 milestone Mar 10, 2019
@johnleider johnleider self-assigned this Mar 10, 2019
@johnleider
Copy link
Member

This has been resolved for v2.0 https://codepen.io/johnjleider/pen/agzOoL

@KaelWD
Copy link
Member

KaelWD commented Jun 16, 2019

@johnleider that commit didn't change anything here, it was from the toolbar's translateY which has moved to v-app-bar.

@medeman tracking this as #5351 now

@KaelWD KaelWD removed this from the v2.0.0 milestone Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VMenu VMenu platform specific The issue only occurs on a specific platform
Projects
None yet
Development

No branches or pull requests

5 participants