Skip to content

Commit

Permalink
fix(VSelect): fix entry animation and positioning
Browse files Browse the repository at this point in the history
  • Loading branch information
johnleider committed Apr 22, 2019
1 parent 9c4c0f9 commit ae8f92a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
1 change: 1 addition & 0 deletions packages/vuetify/src/components/VInput/VInput.sass
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
display: flex
flex: 1 1 auto
font-size: 16px
letter-spacing: normal
text-align: left

.v-progress-linear
Expand Down
3 changes: 2 additions & 1 deletion packages/vuetify/src/components/VList/VListItem.sass
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
align-items: center
display: flex
flex: 1 1 100%
letter-spacing: normal
min-height: $list-item-min-height
outline: none
padding: 0 16px
Expand Down Expand Up @@ -83,7 +84,7 @@
flex-wrap: wrap
flex: 1 1
overflow: hidden
padding: 16px 0
padding: 12px 0

> *
line-height: 1.1
Expand Down
6 changes: 6 additions & 0 deletions packages/vuetify/src/components/VMenu/VMenu.sass
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@
&--active
pointer-events: none

&--auto
.v-list-item
transition-property: transform, opacity
transition-duration: .3s
transition-timing-function: map-get($transition, 'fast-in-fast-out')

&--fixed
position: fixed

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export default {
const tileDistanceFromMenuTop = activeTile.offsetTop - this.calcScrollPosition()
const firstTileOffsetTop = $el.querySelector('.v-list-item').offsetTop

return this.computedTop - tileDistanceFromMenuTop - firstTileOffsetTop
return this.computedTop - tileDistanceFromMenuTop - firstTileOffsetTop - 1
}
}
}

0 comments on commit ae8f92a

Please sign in to comment.